This project is read-only.

Make the Managers public instead of internal

Nov 18, 2011 at 6:04 PM

I was building some custom NAnt tasks to help make a complex build a little cleaner, and I wanted some tasks to help populate a dictionary that could then be accessed in the nant build file through the NAntCollections tasks.  It looked like the best way to do that was to call DictionaryManager.GetDictionary, but the DictionaryManager was set up to be internal.  I went ahead and made it public and recompiled, but I thought I would bring this sort of case up here so you could think about whether internal was really the access modifier you wanted on the DictionaryManager and ListManager classes. 

Also, I noticed those two manager classes are abstract, but they just include static methods and are never derived from.  Perhaps the static keyword would be more appropriate?